franzz/livetrail
1
0
Fork 0
Code Issues Pull Requests Actions Releases Wiki Activity

Close session earlier if not required
Deploy Spot / deploy (push) Successful in 16s
Details

Browse Source
This commit is contained in:
franzz
2026-08-10 23:55:48 +02:00
parent d6c897beeb
commit a09fb9792f
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Controller.php
+19 -6
View File
@@ -22,6 +22,10 @@ class Controller extends PhpObject
'admin_create', 'admin_create',
'admin_delete' 'admin_delete'
); );
const SESSION_WRITING_ACTIONS = array(
'login',
'logout'
);
private Spot $oSpot; private Spot $oSpot;
private array $asReq; private array $asReq;
@@ -67,17 +71,21 @@ class Controller extends PhpObject
//Create Spot Instance //Create Spot Instance
$this->oSpot = new Spot($sProcessPage, $this->asReq['t']); $this->oSpot = new Spot($sProcessPage, $this->asReq['t']);
$this->oSpot->setProjectId($this->asReq['id_project']);
//Validate CSRF & dispatch //Validate CSRF, then release the session lock before long-running work.
if(!$this->validateMutationRequest($sAction)) $sResult = Spot::getJsonResult(false, Spot::UNAUTHORIZED); $bValidMutationRequest = $this->validateMutationRequest($sAction);
elseif($sAction == '') $sResult = $this->oSpot->getAppMainPage($this->getCsrfToken()); if(!$bValidMutationRequest || !in_array($sAction, self::SESSION_WRITING_ACTIONS, true)) $this->closeSession();
else $sResult = $this->dispatch($sAction);
if(!$bValidMutationRequest) $sResult = Spot::getJsonResult(false, Spot::UNAUTHORIZED);
else {
$this->oSpot->setProjectId($this->asReq['id_project']);
$sResult = ($sAction == '')?$this->oSpot->getAppMainPage($this->getCsrfToken()):$this->dispatch($sAction);
}
//Clean errors //Clean errors
$sDebug = ob_get_clean(); $sDebug = ob_get_clean();
if($sDebug != '') $this->oSpot->addUncaughtError($sDebug); if($sDebug != '') $this->oSpot->addUncaughtError($sDebug);
if(session_status() === PHP_SESSION_ACTIVE) session_write_close(); $this->closeSession();
return $sResult; return $sResult;
} }
@@ -124,6 +132,11 @@ class Controller extends PhpObject
return PHP_SAPI === 'cli' || ($sServerToken !== '' && is_string($sClientToken) && hash_equals($sServerToken, $sClientToken)); return PHP_SAPI === 'cli' || ($sServerToken !== '' && is_string($sClientToken) && hash_equals($sServerToken, $sClientToken));
} }
private function closeSession(): void
{
if(session_status() === PHP_SESSION_ACTIVE) session_write_close();
}
private function dispatch(string $sAction): string private function dispatch(string $sAction): string
{ {
return match($sAction) { return match($sAction) {