Fix link in edited messages

Redirect note to me.sap.com
Remove # operator
2023-08-09 22:58:23 +02:00 · 2023-08-08 20:06:57 +02:00 · 2022-03-11 15:03:12 +01:00 · 2022-03-11 15:00:27 +01:00 · 2022-03-11 14:55:19 +01:00 · 2022-03-11 14:49:21 +01:00
4 changed files with 73 additions and 53 deletions
--- a/inc/databap.php
+++ b/inc/databap.php
@@ -216,7 +216,6 @@ class Databap extends PhpObject
 		header('Content-Type: text/html; charset='.Settings::TEXT_ENC);
 		mb_internal_encoding(Settings::TEXT_ENC);
 		mb_http_output(Settings::TEXT_ENC);
-		mb_http_input(Settings::TEXT_ENC);
 		mb_language('uni');
 		mb_regex_encoding(Settings::TEXT_ENC);

@@ -2272,12 +2271,15 @@ class Databap extends PhpObject
 			else //Normal message
 			{
 				//Internal links
-				$asMessages['messages'][$iMessageId]['message'] = Toolbox::findReplaceLinks($asMessages['messages'][$iMessageId]['message']);
+				$sFormatedMsg = Toolbox::findReplaceLinks($asMessages['messages'][$iMessageId]['message']);

 				//Dynamic chan link
 				$asPatterns = '/(^|\s)#(\w*[^\s]+\w*)/u';
 				$asLinks = '\1<span class="chan_link clickable">#<span class="chan_text">\2</span></span>';
-				$asMessages['messages'][$iMessageId]['message'] = preg_replace($asPatterns, $asLinks, $asMessages['messages'][$iMessageId]['message']);
+				$sFormatedMsg = preg_replace($asPatterns, $asLinks, $sFormatedMsg);
+
+				if($asMessages['messages'][$iMessageId]['message'] != $sFormatedMsg) $asMessages['messages'][$iMessageId]['message_original'] = $asMessages['messages'][$iMessageId]['message'];
+				$asMessages['messages'][$iMessageId]['message'] = $sFormatedMsg;
 			}
 		}

--- a/inc/reader.php
+++ b/inc/reader.php
@@ -46,8 +46,8 @@ class Reader extends PhpObject
 								'CASERESPECTING','CASTING','CENTERED','CHAIN','CHANGE','CHANGING','CHARACTER','CHECK','CHECKBOX',
 								'CHECKBOXSYMBOLICONLINE','CLASS','CLASS-DATA','CLASS-EVENTS','CLASS-METHODS','CLEANUP','CLEAR','CLIENT','CLOCK',
 								'CODE','COL_BACKGROUND','COL_HEADING','COL_NORMAL','COL_TOTAL','COLLECT','COLOR','COLUMN','COMMENT','COMMIT',
-								'COMMON','COMMUNICATION','COMPARING','COMPONENTS','COMPUTE','CONCATENATE','CONDENSE','CONSTANTS','CONTEXT',
-								'CONTEXTS','CONTINUE','CONTROL','CONTROLS','CONVERSION','CONVERT','COUNTRY','COUNTY','CURRENT','CURSOR',
+								'COMMON','COMMUNICATION','COMPARING','COMPONENTS','COMPUTE','CONCATENATE', 'COND', 'CONDENSE','CONSTANTS','CONTEXT',
+								'CONTEXTS','CONTINUE','CONTROL','CONTROLS','CONVERSION', 'CONV', 'CONVERT','COUNTRY','COUNTY','CURRENT','CURSOR',
 								'CUSTOMER-FUNCTION','DATA','DATABASE','DATASET','DATE','DEALLOCATE','DECIMALS','DEFAULT','DEFAULTUTF-8NON-UNICODE',
 								'DEFERRED','DEFINE','DEFINING','DEFINITION','DELETE','DELETING','DEMAND','DESCENDING','DESCRIBE','DESTINATION',
 								'DIALOG','DIRECTORY','DISTANCE','DISTINCT','DIVIDE-CORRESPONDING','DO','DUPLICATE','DUPLICATES','DURING','DYNAMIC',
@@ -104,7 +104,8 @@ class Reader extends PhpObject
 									'quote'	=> array('&quot;', '&quot;'),
 									'quot2'	=> array('&#039;', '&#039;'),
 									'pipe'	=> array('|', '|'),
-									'curly'	=> array('{', '}') 
+									'curly'	=> array('{', '}'),
+									'tick'	=> array('`', '`')
 								),
 								'iNumber'=>array('1', '2', '3', '4', '5', '6', '7', '8', '9', '0'),
 								'wExpand'=>array('loop'=>'endloop', 'if'=>'endif'),
--- a/masks/chat.html
+++ b/masks/chat.html
@@ -945,19 +945,16 @@ function getMessage(message_info, bReset)
 			$Msg.find('a').addClass('img_box').append($Banner);
 		}

-		if(message_info.edited) {
-
-		}
-
 		//Adding message to channel panel
 		$Message = $('<p>', {'class':message_info.msg_class+' class_'+sChanKeyName+' hide round_right', 'data-id':message_info.id, 'data-id-user':message_info.id_user})
-					.data('orig_msg', message_info.message)
+					.data('orig_msg', message_info.message_original || message_info.message)
+					.data('disp_msg', message_info.message)
 					.append($('<span>', {'class':'time'}).text(((message_info.date==databap.consts.cur_date)?'':message_info.date+' - ')+message_info.time))
 					.append($Msg)
 					.append($('<span>', {'class':'status'}).text('modifié'));
 		$Message.find('.chan_link').click(function(){joinChan($(this).find('.chan_text').text());});
 		$Message.find('.user').click(setPm);
-		$Message.find('.editable').hover(toggleEditButton).click(onMessageEditClick);
+		$Message.find('.editable').on('mouseenter', toggleEditButton).on('mouseleave', toggleEditButton).click(onMessageEditClick);

 		if(message_info.edited) $Message.find('.status').show();
 	}
@@ -998,6 +995,7 @@ function addMessage(message_info, bReset) {
 		let oOrigMsg = databap.tmp(['messages', message_info.id_message_ref]);
 		if(oOrigMsg) {
 			oOrigMsg.message = message_info.message;
+			oOrigMsg.message_original = message_info.message_original || message_info.message;
 			oOrigMsg.msg_class = message_info.msg_class;
 			oOrigMsg.edited = true;

@@ -1039,61 +1037,64 @@ function addMessage(message_info, bReset) {
 	}
 }

-function toggleEditButton()
+function toggleEditButton(eEvent)
 {
 	let $Editable = $(this); //.editable
-	let $EditBtn = $Editable.next('.edit-btn');
-	if($EditBtn.length > 0) $EditBtn.remove();
-	else $Editable.after($('<span>', {'class':'text edit-btn'}).append($('<i>', {'class': 'fa fa-fw fa-c-edit'})));
+	let $EditBtn = $Editable.next('.edit-btn')
+	if(eEvent.type == 'mouseleave' && $EditBtn.length > 0) $EditBtn.remove();
+	if(eEvent.type == 'mouseenter' && $EditBtn.length == 0) $Editable.after($('<span>', {'class':'text edit-btn'}).append($('<i>', {'class': 'fa fa-fw fa-c-edit'})));
 }

-function onMessageEditClick()
+function onMessageEditClick(eClick)
 {
 	let $Editable = $(this);
 	let $Message = $Editable.parents('p');
 	let bPrivate = $Message.hasClass('P');
-	let sDisplayedMsg = $Editable.text();
+	let sDisplayedMsg = $Message.data('disp_msg');
 	let sOriginalMsg = $Message.data('orig_msg');
+	let bEditing = ($Editable.prop('contenteditable') == 'true');

-	$Editable
-		.prop('contenteditable', 'true')
-		.data('disp_msg', sDisplayedMsg)
-		.focus();
-	
-	if(sDisplayedMsg != sOriginalMsg) {
-		let iCaretPos = getCaretPosition($Editable[0]);
-		$Editable.text(sOriginalMsg);
-		setCaretPosition($Editable[0], iCaretPos + sOriginalMsg.indexOf(sDisplayedMsg));
-	} 
-	if(bPrivate) $Message.find('.console').hide();
+	if(!bEditing && !eClick.ctrlKey) {
+		$Editable
+			.prop('contenteditable', 'true')
+			.focus();
+		
+		if(sDisplayedMsg != sOriginalMsg) {
+			//let iCaretPos = getCaretPosition($Editable[0]);
+			$Editable.text(sOriginalMsg);
+			//setCaretPosition($Editable[0], iCaretPos + sOriginalMsg.indexOf(sDisplayedMsg));
+		}
+		
+		if(bPrivate) $Message.find('.console').hide();

-	$Editable
-		.off('focusout keydown keyup')
-		.keyup(function(e) {
-			if(e.keyCode == 9) {
-				e.preventDefault();
-				keyController(e, this);
-			}
-		})
-		.on('focusout keydown', function(e) {
-			let $This = $(this);
-			if(e.type == 'focusout' || e.which == 13) {
-				e.preventDefault();
-				let $Message = $Editable.parents('p');
-				let sOldMsg = $Message.data('orig_msg');
-				let sNewMsg = $This.text();
+		$Editable
+			.off('focusout keydown keyup')
+			.keyup(function(e) {
+				if(e.keyCode == 9) {
+					e.preventDefault();
+					keyController(e, this);
+				}
+			})
+			.on('focusout keydown', function(e) {
+				let $This = $(this);
+				if(e.type == 'focusout' || e.which == 13) {
+					e.preventDefault();
+					let $Message = $Editable.parents('p');
+					let sOldMsg = $Message.data('orig_msg');
+					let sNewMsg = $This.text();

-				if(sOldMsg != sNewMsg) {
 					$This.prop('contenteditable', 'false');
-					editMessage($This.parents('p').data('id'), sNewMsg);
+					if(sOldMsg != sNewMsg) {
+						editMessage($This.parents('p').data('id'), sNewMsg);
+					}
+					else {
+						$This.html($Message.data('disp_msg'));
+						$Message.find('.console').show();
+					}
 				}
-				else {
-					$This.text($This.data('disp_msg'));
-					$Message.find('.console').show();
-				}
-			}
-			else if(e.keyCode == 9) e.preventDefault();
-		});
+				else if(e.keyCode == 9) e.preventDefault();
+			});
+	}
 }

 function editMessage(iMsgId, sNewMsg)
--- a/masks/note.html
+++ b/masks/note.html
@@ -8,6 +8,7 @@
 <script type="text/javascript">
 databap.pageInit = function()
 {
+	/*
 	databap.tmp('note', 'integer');
 	var $Frame = $('#note_frame');
 	
@@ -34,6 +35,21 @@ databap.pageInit = function()
 		
 		databap.tmp('note', iNote);
 	}
+	*/
+
+	$('#note_id')
+		.addDefaultValue('N° note')
+		.on('keyup', function() {
+			$('#submit').attr('href', 'https://me.sap.com/notes/'+$('#note_id').val());
+		});
+	$('#note_form').addButton('ok', 'Ok', '', 'submit', 'heavy');
+	
+	var iNote = databap.vars.id;
+	if(isNumeric(iNote) && iNote > 0) {
+		self.addBufferIcon();
+		$('#note_id').val(iNote).focus();
+		self.goToExternalLink('https://me.sap.com/notes/'+iNote);
+	}
 }

 /*
Author	SHA1	Message	Date
Franzz	c0c89fe50a	Fix link in edited messages	2023-08-09 22:58:23 +02:00
Franzz	5c629e9bf6	Redirect note to me.sap.com	2023-08-08 20:06:57 +02:00
Franzz	beb2f19d27	Remove # operator	2022-03-11 15:03:12 +01:00
Franzz	483781d1fb	Fix # operator	2022-03-11 15:00:27 +01:00
Franzz	1c5e04458e	Add backtick as string separator	2022-03-11 14:55:19 +01:00
Franzz	3b73ca626a	Add a few more 7.40 syntax key words	2022-03-11 14:49:21 +01:00